Add automated SDK example sync with dynamic code imports#70
Add automated SDK example sync with dynamic code imports#70GreatSoshiant wants to merge 21 commits intomasterfrom
Conversation
…to internal, add external examples via submodule
…ion on external examples
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chrisco512
left a comment
chrisco512
left a comment
There was a problem hiding this comment.
Great work overall, just need to align all the examples to 0.9. Some of the app examples have not been bumped. If those are too complicated we can upgrade them in a subsequent PR. However, many of the basic examples are using 0.10.0-beta for the SDK version number.
| [dependencies] | ||
| alloy-primitives = "1.0" | ||
| alloy-sol-types = "1.0" | ||
| stylus-sdk = "0.10.0-beta.0" |
There was a problem hiding this comment.
Can we stick with 0.9.0 here? I don't think there are any dependencies on 0.10.0 right?
| alloy-primitives = "1.0" | ||
| alloy-sol-types = "1.0" | ||
| sha3 = "0.10" | ||
| stylus-sdk = "0.10.0-beta.0" |
There was a problem hiding this comment.
Same here, if not absolutely necessary, let's reduce to 0.9.0
| alloy = { version = "1.0", features = ["contract", "signer-local", "rpc-types", "sha3-keccak"] } | ||
| eyre = "0.6" | ||
| tokio = "1.44" | ||
| stylus-sdk = { version = "0.10.0-beta.0", features = ["stylus-test"] } |
| [dependencies] | ||
| alloy-primitives = "1.0" | ||
| alloy-sol-types = "1.0" | ||
| stylus-sdk = "0.10.0-beta.0" |
| [dependencies] | ||
| alloy-primitives = "1.0" | ||
| alloy-sol-types = "1.0" | ||
| stylus-sdk = "0.10.0-beta.0" |
There was a problem hiding this comment.
Think this example needs to be bumped up to 0.9
There was a problem hiding this comment.
Also prob needs a version bump to 0.9
2 participants
In this PR: